feat(generation): align validated SSE adapter with backend tasks - #110
Open
xyh202131 wants to merge 3 commits into
Open
feat(generation): align validated SSE adapter with backend tasks#110xyh202131 wants to merge 3 commits into
xyh202131 wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Review summary: two issues stand out.
Findings without inline locations
frontend/src/entities/generation/index.ts:102: The complete-animation result type only preserves URLs, but the backend action frame DTO already carriesduration_msand the frontendFramemodel can storedurationMs. Once this adapter maps the task intoGenerationResult, that timing data is gone and downstream character writes will have to invent defaults.
This was referenced Aug 4, 2026
实测反馈:契约对得上,但终态不关流会无限重连;另外目前零 UI 消费者在集成分支( 1. 契约是对的,两处可以放心
2. 终态之后 EventSource 会每 3 秒重连一次,需要显式 close服务端发完终态事件就关流,但响应里带了 也就是说:任务早就结束了,前端还在每 3 秒打一次请求,且业务回调会被重复触发。 修法二选一(前者更稳):
3. 目前全仓没有调用方搜 |
This was referenced Aug 5, 2026
Closed
xyh202131
force-pushed
the
feat/generation-sse-adapter
branch
from
August 7, 2026 10:37
b0bc0ce to
33b4863
Compare
xyh202131
force-pushed
the
feat/generation-sse-adapter
branch
from
August 8, 2026 08:11
33b4863 to
d8d171b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
本次更新
id和旧字段task_id,统一转换为前端taskId。验证